So, decided to throw a few more parts at the 911, because... why not... so far they're pretty cheap.
Got a Bosch 3.8bar fuel pressure regulator for about $50, as I had a suspicion the old FPR wasn't great - the vacuum tube was a little wet.
Removed old FPR - used needlenosed plier to remove the retaining clip, and the old FPR wedged in pretty tight, so yeeted it out with some pliers. You can see a drop of dirty old fuel dripping from the vacuum port which is no good.
New replacement fuel pressur regulator. Push it into the fuel rail, and press down on it while reinserting the retaining clip.
Started up again - still terrible idle and stalling almost immediately after starting. Interestingly, getting some different codes. P1602 is because I disconnected the battery for an hour. P0341 is camshaft sensor to bank 1 - actually, I've been ignoring the code for a couple of years now.
P1514 is to do with the idle air control valve - haven't had that code before, and I've only jsut removed, cleaned and tested it and replaced it.
Anyway, next thing to do, I grabbed my fuel pressure tester and hooked it up the the fuel rail over Bank 2.
With key in, engine off and fuel pump on, we get a solid 3.3bar that doesn't fall away.
With engine running, and foot holding the throttle open a bit, we get 3.8bar as expected
So... i'm thinking the fuel pump is good, new fuel pressure regulator is good... erm - worth checking the fuel injectors? Doesn't seem like a big deal to remove them and visually inspect at least. Just drop the engine a couple of inches and remove a few wiring plugs and bolts. Maybe next weekend.